FAC-34 feat: implement login strategy pattern for auth service#60
Merged
FAC-34 feat: implement login strategy pattern for auth service#60
Conversation
Refactor AuthService.Login() to use a strategy pattern that separates local password authentication from Moodle SSO authentication. - Add LoginStrategy interface with priority-based ordering - Create LocalLoginStrategy (priority 10) for local password auth - Create MoodleLoginStrategy (priority 100) for Moodle SSO - Strategies auto-sorted by priority in AuthService constructor - Add eslint rule to allow underscore-prefixed unused params - Preserve transactional integrity and MoodleConnectivityError handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
y4nder
added a commit
that referenced
this pull request
Mar 9, 2026
Refactor AuthService.Login() to use a strategy pattern that separates local password authentication from Moodle SSO authentication. - Add LoginStrategy interface with priority-based ordering - Create LocalLoginStrategy (priority 10) for local password auth - Create MoodleLoginStrategy (priority 100) for Moodle SSO - Strategies auto-sorted by priority in AuthService constructor - Add eslint rule to allow underscore-prefixed unused params - Preserve transactional integrity and MoodleConnectivityError handling
y4nder
added a commit
that referenced
this pull request
Mar 9, 2026
…38, FAC-39] (#76) * FAC-30 chore removed semantic release feature (#55) * FAC-32 yaml file for contract schema (#58) * FAC-33 feat: add Moodle connectivity error handling with timeouts (#59) When Moodle is unreachable or times out, the API now returns a clear 401 Unauthorized with "Moodle service is currently unreachable" instead of a generic 500 error. This improves frontend error handling and server-side debugging with detailed logging. - Add MoodleConnectivityError custom error class with 10s request timeout - Catch connectivity errors in AuthService.Login and map to 401 response - Enhance logging in MoodleSyncService and MoodleUserHydrationService - Add 5 unit tests for connectivity error scenarios * FAC-34 feat: implement login strategy pattern for auth service (#60) Refactor AuthService.Login() to use a strategy pattern that separates local password authentication from Moodle SSO authentication. - Add LoginStrategy interface with priority-based ordering - Create LocalLoginStrategy (priority 10) for local password auth - Create MoodleLoginStrategy (priority 100) for Moodle SSO - Strategies auto-sorted by priority in AuthService constructor - Add eslint rule to allow underscore-prefixed unused params - Preserve transactional integrity and MoodleConnectivityError handling * FAC-35 feat: added Refresh token cleanup (#61) * FAC-35 feat: added Refresh token cleanup * fix: linting issues * fix: fixing linting issue * FAC-36 chore: updated documentation (#62) * FAC-36 chore: updated documentation * chore: updated data model documentation * FAC-37 feat: normalize role persisting and retrieval (#65) * chore: Update Documentation * FAC-38 feat: added faculty instructor context on enrollment response (#73) * FAC-39 chore: security issues from dependabot (#75)
y4nder
added a commit
that referenced
this pull request
Mar 9, 2026
…38, FAC-39] (#76) * FAC-30 chore removed semantic release feature (#55) * FAC-32 yaml file for contract schema (#58) * FAC-33 feat: add Moodle connectivity error handling with timeouts (#59) When Moodle is unreachable or times out, the API now returns a clear 401 Unauthorized with "Moodle service is currently unreachable" instead of a generic 500 error. This improves frontend error handling and server-side debugging with detailed logging. - Add MoodleConnectivityError custom error class with 10s request timeout - Catch connectivity errors in AuthService.Login and map to 401 response - Enhance logging in MoodleSyncService and MoodleUserHydrationService - Add 5 unit tests for connectivity error scenarios * FAC-34 feat: implement login strategy pattern for auth service (#60) Refactor AuthService.Login() to use a strategy pattern that separates local password authentication from Moodle SSO authentication. - Add LoginStrategy interface with priority-based ordering - Create LocalLoginStrategy (priority 10) for local password auth - Create MoodleLoginStrategy (priority 100) for Moodle SSO - Strategies auto-sorted by priority in AuthService constructor - Add eslint rule to allow underscore-prefixed unused params - Preserve transactional integrity and MoodleConnectivityError handling * FAC-35 feat: added Refresh token cleanup (#61) * FAC-35 feat: added Refresh token cleanup * fix: linting issues * fix: fixing linting issue * FAC-36 chore: updated documentation (#62) * FAC-36 chore: updated documentation * chore: updated data model documentation * FAC-37 feat: normalize role persisting and retrieval (#65) * chore: Update Documentation * FAC-38 feat: added faculty instructor context on enrollment response (#73) * FAC-39 chore: security issues from dependabot (#75)
Merged
y4nder
added a commit
that referenced
this pull request
Mar 9, 2026
* FAC-30 chore removed semantic release feature (#55) * FAC-32 yaml file for contract schema (#58) * FAC-33 feat: add Moodle connectivity error handling with timeouts (#59) When Moodle is unreachable or times out, the API now returns a clear 401 Unauthorized with "Moodle service is currently unreachable" instead of a generic 500 error. This improves frontend error handling and server-side debugging with detailed logging. - Add MoodleConnectivityError custom error class with 10s request timeout - Catch connectivity errors in AuthService.Login and map to 401 response - Enhance logging in MoodleSyncService and MoodleUserHydrationService - Add 5 unit tests for connectivity error scenarios * FAC-34 feat: implement login strategy pattern for auth service (#60) Refactor AuthService.Login() to use a strategy pattern that separates local password authentication from Moodle SSO authentication. - Add LoginStrategy interface with priority-based ordering - Create LocalLoginStrategy (priority 10) for local password auth - Create MoodleLoginStrategy (priority 100) for Moodle SSO - Strategies auto-sorted by priority in AuthService constructor - Add eslint rule to allow underscore-prefixed unused params - Preserve transactional integrity and MoodleConnectivityError handling * FAC-35 feat: added Refresh token cleanup (#61) * FAC-35 feat: added Refresh token cleanup * fix: linting issues * fix: fixing linting issue * FAC-36 chore: updated documentation (#62) * FAC-36 chore: updated documentation * chore: updated data model documentation * FAC-37 feat: normalize role persisting and retrieval (#65) * chore: Update Documentation * FAC-38 feat: added faculty instructor context on enrollment response (#73) * FAC-39 chore: security issues from dependabot (#75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthService.Login()to use a strategy pattern separating local password auth from Moodle SSOLoginStrategyinterface with priority-based ordering for extensibilityLocalLoginStrategy(priority 10) andMoodleLoginStrategy(priority 100)Changes
src/modules/auth/strategies/- interface, implementations, and testsAuthServicenow injects and sorts strategies by priorityeslint.config.mjs- addedargsIgnorePattern: '^_'ruleTest plan